Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11879: Rename some generic methods to match our naming convention #667

Conversation

amousset
Copy link
Member

@amousset
Copy link
Member Author

Commit modified

@amousset amousset force-pushed the ust_11879/rename_some_generic_methods_to_match_our_naming_convention branch from 77cbb36 to 4c9f7f5 Compare December 14, 2017 09:59
@amousset
Copy link
Member Author

PR rebased

@amousset amousset force-pushed the ust_11879/rename_some_generic_methods_to_match_our_naming_convention branch from 4c9f7f5 to 2dcf3c4 Compare December 14, 2017 10:03
@amousset
Copy link
Member Author

Commit modified

@amousset amousset force-pushed the ust_11879/rename_some_generic_methods_to_match_our_naming_convention branch from 2dcf3c4 to 07d25af Compare December 14, 2017 16:00
@peckpeck
Copy link
Member

not mergeable anymore

@amousset
Copy link
Member Author

Commit modified

@amousset amousset force-pushed the ust_11879/rename_some_generic_methods_to_match_our_naming_convention branch from 07d25af to 7b273c8 Compare December 19, 2017 09:56
@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Your branch is up-to-date with 'NRM/master'.
Already up-to-date.
Deleted branch master_test (was 77f173a).
Updating 249892f..7b273c8
[...]
Running merge tests
 $ cd "/var/lib/quality-assistant/ncf" && ./qa-test --merge

-- stderr --
From github.com:amousset/ncf
 * [new branch]      ust_11879/rename_some_generic_methods_to_match_our_naming_convention -> ust_11879/rename_some_generic_methods_to_match_our_naming_convention_pr
Switched to branch 'master'
Switched to a new branch 'master_test'
make: *** [test-common] Error 1

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/ncf/pull/667 --test to test with upmerging.
After this, you can remove the Ready for merge tag
-- Your faithful QA

@amousset amousset force-pushed the ust_11879/rename_some_generic_methods_to_match_our_naming_convention branch from 7b273c8 to 94be8f6 Compare January 2, 2018 14:25
@amousset
Copy link
Member Author

amousset commented Jan 2, 2018

PR rebased

@amousset amousset force-pushed the ust_11879/rename_some_generic_methods_to_match_our_naming_convention branch from 94be8f6 to ae83c61 Compare January 16, 2018 15:45
@amousset
Copy link
Member Author

PR replaced by #679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants