-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #12096: Rename some generic methods to match our naming convention - part2 #701
Conversation
Do not merge, tests not passing |
Commit modified |
dd4ef51
to
7ebf337
Compare
Commit modified |
7ebf337
to
a95254e
Compare
Commit modified |
a95254e
to
cdafaa6
Compare
All tests fixed, ready for review! |
Commit modified |
cdafaa6
to
4bb7e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to review friendly names.
Everything else looks good to me
@@ -23,13 +23,13 @@ | |||
# @parameter lines Line(s) to add in the file | |||
# @parameter enforce Enforce the file to contain only line(s) defined (true or false) | |||
# | |||
# @class_prefix file_content | |||
# @class_prefix file_lines_present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should change the prefix of existing generic methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was wrongly changed in the first rename PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
# | ||
##################################################################################### | ||
|
||
# @name File ensure keys -> values present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could rename the friendly name too
# | ||
##################################################################################### | ||
|
||
# @name File ensure line in INI section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too
Commit modified |
4bb7e92
to
7537972
Compare
tree/30_generic_methods/$
Outdated
@@ -0,0 +1,42 @@ | |||
##################################################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file name ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea where is comes from...
# | ||
##################################################################################### | ||
|
||
# @name File from local source recurse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recursion
# | ||
##################################################################################### | ||
|
||
# @name File from remote source recurse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recursion
# | ||
##################################################################################### | ||
|
||
# @name File key -> value present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the '->' here and not in other names ?
# | ||
##################################################################################### | ||
|
||
# @name File key-value in INI section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'-' here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put "-" everywhere as it is clearer than "key value" and shorter than "key -> value"
# | ||
##################################################################################### | ||
|
||
# @name Create symlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create ?
Commit modified |
7537972
to
082e39a
Compare
Commit modified |
082e39a
to
c1b105e
Compare
Commit modified |
c1b105e
to
8232866
Compare
ping @peckpeck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good
OK, merging this PR |
Commit modified |
8232866
to
1923cf9
Compare
OK, merging this PR |
Commit modified |
1923cf9
to
2437223
Compare
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/12096