Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5091: Add ncf-builder in ncf repo #71

Merged

Conversation

VinceMacBuche
Copy link
Member

@jooooooon
Copy link
Member

This PR needs rebasing, probably best to wait until #70 is merged though.

However, I'm not in any position to review this code. Maybe we should get @ncharles or @fanf to read through it before committing? What do you think, @VinceMacBuche ?

// ncf technique container
$scope.techniques;

//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot the comment ?

ncharles added a commit that referenced this pull request Jun 25, 2014
@ncharles ncharles merged commit e543c24 into Normation:master Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants