Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #12464: Technique editor returning an error when saving #744

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Fixes #12464: Technique editor returning an error when saving #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/ncf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def parse_bundlefile_metadata(content, bundle_type):
for param in parameters:
parameter_name = param["name"]
constraints = param_constraints.get(param["name"], ncf_constraints.default_constraint)
for key, constraint in constraints.iteritems():
for key, constraint in constraints.items():
check = ncf_constraints.check_constraint_type(key, constraint)
if not check['result']:
raise NcfError("Value for constraint '" + key + "' of parameter '"+ param['name'] +"' is not valid, "+", ".join(check["errors"]))
Expand Down
2 changes: 1 addition & 1 deletion tools/ncf_constraints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def check_parameter(parameter_value, parameter_constraints):
if re.search(r'[$@][{(][$@{(a-zA-Z0-9[\]_.-]+[})]', parameter_value) is not None :
constraint_set = variable_constraints

for (constraint_name, constraint_value) in parameter_constraints.iteritems():
for (constraint_name, constraint_value) in parameter_constraints.items():
if constraint_name in constraint_set:
constraint = constraint_set[constraint_name]
constraint_check = constraint['check'](parameter_value,constraint_value)
Expand Down