Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #12164: Add a package provider for zypper patterns #762

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fixes #12164: Add a package provider for zypper patterns #762

merged 1 commit into from
Oct 8, 2018

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented May 25, 2018

amousset
amousset reviewed May 25, 2018
View reviewed changes
tree/30_generic_methods/package_present.cf Outdated
@@ -25,9 +25,9 @@
# @parameter_constraint version "allow_empty_string" : true
# @parameter architecture Architecture of the package, can be an architecture name or "default" (defaults to "default")
# @parameter_constraint architecture "allow_empty_string" : true
# @parameter provider Package provider to use, can be "yum", "apt", "pkg" or "default" for system default package manager (defaults to "default")
# @parameter provider Package provider to use, can be "yum", "apt", "zypper", "zypper_pattern", "pkg" or "default" for system default package manager (defaults to "default")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@amousset
Copy link
Member

amousset commented May 25, 2018 •
edited
Loading

You should also update the technique to add this new field (one for 4.1 with 1.0 and 1.1 version, and one on 1.2 for 4.3

@Fdall
Copy link
Contributor Author

Fdall commented May 25, 2018

Here are the wip for the different versions:
Fdall/rudder-techniques@27606c4
Fdall/rudder-techniques@3bfd713

peckpeck
peckpeck previously approved these changes May 29, 2018
View reviewed changes
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/762
-- Your faithful QA

@Fdall
Copy link
Contributor Author

Fdall commented May 30, 2018

Commit modified

@Fdall Fdall force-pushed the ust_12164/add_a_package_provider_for_zypper_patterns branch from 6e5ae35 to 4981ee2 Compare May 30, 2018 08:36
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/762
-- Your faithful QA

@peckpeck
Copy link
Member

@Fdall you must merge this by yourself

@Fdall
Copy link
Contributor Author

Fdall commented Jun 25, 2018

We should not merge this PR yet because we are not sure of what a zypper pattern remove/updtate should exactly do.

@Fdall
Copy link
Contributor Author

Fdall commented Jul 12, 2018

Commit modified

@Fdall Fdall force-pushed the ust_12164/add_a_package_provider_for_zypper_patterns branch from 4981ee2 to a2859a5 Compare July 12, 2018 12:32
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/762
-- Your faithful QA

@peckpeck
Copy link
Member

@Fdall you must merge this by yourself

@Fdall Fdall force-pushed the ust_12164/add_a_package_provider_for_zypper_patterns branch from a2859a5 to 35b7acd Compare August 14, 2018 16:58
@Fdall
Copy link
Contributor Author

Fdall commented Aug 14, 2018

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/762
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/549/console)

amousset
amousset reviewed Aug 14, 2018
View reviewed changes
tests/acceptance/10_ncf_internals/unsafe/modules/zypper_pattern_module.cf Outdated
#
#####################################################################################

# @agent_version >=3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this

amousset
amousset reviewed Aug 14, 2018
View reviewed changes
tests/acceptance/10_ncf_internals/unsafe/modules/zypper_pattern_module.cf Outdated
@@ -0,0 +1,352 @@
#####################################################################################
# Copyright 2016 Normation SAS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018

amousset
amousset reviewed Aug 14, 2018
View reviewed changes
tree/10_ncf_internals/modules/packages/zypper_pattern Outdated
#!/usr/bin/python

#####################################################################################
# Copyright 2016 Normation SAS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018

@Fdall
Copy link
Contributor Author

Fdall commented Aug 14, 2018

There is no test for multiple input in the module, because testing it in cfengine was too much of a pain.
There is also no tests on limit cases for the moment, nor with special arch specification.

amousset
amousset previously requested changes Aug 14, 2018
View reviewed changes
Copy link
Member

@amousset amousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge

@Fdall Fdall force-pushed the ust_12164/add_a_package_provider_for_zypper_patterns branch from 35b7acd to 6da0676 Compare August 16, 2018 10:11
@Fdall
Copy link
Contributor Author

Fdall commented Aug 16, 2018

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/762
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/2424/console)

@Fdall
Copy link
Contributor Author

Fdall commented Oct 8, 2018

OK, merging this PR

@Fdall Fdall merged commit 6da0676 into Normation:branches/rudder/4.1 Oct 8, 2018
@Fdall
Copy link
Contributor Author

Fdall commented Oct 8, 2018

OK, merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

@amousset amousset amousset left review comments

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
4 participants
@Fdall @amousset @Normation-Quality-Assistant @peckpeck