-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #12164: Add a package provider for zypper patterns #762
Fixes #12164: Add a package provider for zypper patterns #762
Conversation
@@ -25,9 +25,9 @@ | |||
# @parameter_constraint version "allow_empty_string" : true | |||
# @parameter architecture Architecture of the package, can be an architecture name or "default" (defaults to "default") | |||
# @parameter_constraint architecture "allow_empty_string" : true | |||
# @parameter provider Package provider to use, can be "yum", "apt", "pkg" or "default" for system default package manager (defaults to "default") | |||
# @parameter provider Package provider to use, can be "yum", "apt", "zypper", "zypper_pattern", "pkg" or "default" for system default package manager (defaults to "default") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot!
You should also update the technique to add this new field (one for 4.1 with 1.0 and 1.1 version, and one on 1.2 for 4.3 |
Here are the wip for the different versions: |
This PR is not mergeable to upper versions. |
Commit modified |
6e5ae35
to
4981ee2
Compare
This PR is not mergeable to upper versions. |
@Fdall you must merge this by yourself |
We should not merge this PR yet because we are not sure of what a zypper pattern remove/updtate should exactly do. |
Commit modified |
4981ee2
to
a2859a5
Compare
This PR is not mergeable to upper versions. |
@Fdall you must merge this by yourself |
a2859a5
to
35b7acd
Compare
Commit modified |
This PR is not mergeable to upper versions. |
# | ||
##################################################################################### | ||
|
||
# @agent_version >=3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this
@@ -0,0 +1,352 @@ | |||
##################################################################################### | |||
# Copyright 2016 Normation SAS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2018
#!/usr/bin/python | ||
|
||
##################################################################################### | ||
# Copyright 2016 Normation SAS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2018
There is no test for multiple input in the module, because testing it in cfengine was too much of a pain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not merge
35b7acd
to
6da0676
Compare
Commit modified |
This PR is not mergeable to upper versions. |
OK, merging this PR |
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/12164