Fixes #12722: Create a generic method to create a condition that expires after some time #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…res after some time
ncharles
requested changes
Jun 6, 2018
There was a problem hiding this comment.
There is not enough documentation on how to use it - i cannot understand, by reading the code, how it should work.
There isn't any test also - you should definitively add one (you can try to set the class, then run a sleep and an agent, and see if the agent see the clas or not))
| @@ -0,0 +1,56 @@ | |||
| ##################################################################################### | |||
| # Copyright 2015 Normation SAS | |||
| # The created condition (class in CFEngine speaking) is global to the agent. | ||
| # | ||
| # @parameter condition_prefix The condition prefix | ||
| # @parameter duration The timer duration in munutes |
|
ping @peckpeck |
|
Needs a retarget to 5.0. |
|
We will close that until we have a better spec on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12722