Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12767: Add a test for custom jinja filters and tests #773

Conversation

amousset
Copy link
Member

@amousset
Copy link
Member Author

PR rebased

@amousset amousset force-pushed the arch_12767/add_a_test_for_custom_jinja_filters_and_tests branch from 6a9d59f to 95fa262 Compare June 11, 2018 12:56
@amousset
Copy link
Member Author

Commit modified

@amousset amousset force-pushed the arch_12767/add_a_test_for_custom_jinja_filters_and_tests branch from 95fa262 to 628cf76 Compare June 11, 2018 13:22
@amousset
Copy link
Member Author

Do not merge for now, missing change in the techniques.

@amousset
Copy link
Member Author

Commit modified

@amousset amousset force-pushed the arch_12767/add_a_test_for_custom_jinja_filters_and_tests branch from 628cf76 to 6ce041d Compare June 11, 2018 14:24
@@ -140,7 +160,7 @@
#
# Use the following template:
#
# ```mustache
# ```jinja2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/773
-- Your faithful QA

@amousset
Copy link
Member Author

OK, merging this PR

@amousset amousset merged commit 6ce041d into Normation:branches/rudder/4.1 Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants