Fixes #12798: zypper module arch and version specification for zypper commands is not correct #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge for now. |
amousset
commented
Jun 19, 2018
| @@ -33,7 +33,7 @@ import re | |||
|
|
|||
| rpm_cmd = os.environ.get('CFENGINE_TEST_RPM_CMD', "/bin/rpm") | |||
| rpm_quiet_option = ["--quiet"] | |||
| rpm_output_format = "Name=%{name}\nVersion=%{version}-%{release}\nArchitecture=%{arch}\n" | |||
| rpm_output_format = "Name=%{name}\nVersion=%|EPOCH?{%{epoch}:}:{}|%{version}-%{release}\nArchitecture=%{arch}\n" | |||
There was a problem hiding this comment.
This syntax works in RHEL3 ans SLES11, it should be safe to use everywhere
There was a problem hiding this comment.
Works on SLES11, I still need to test on SLES10 and SLES12.
amousset
changed the title
|
Commit modified |
amousset
force-pushed
the
bug_12798/epoch_in_software_versions_is_not_stored_by_zypper_and_yum_module_which_breaks_version_detection
branch
from
219d654
to
c111b32
Compare
…le, which breaks version detection
|
Commit modified |
amousset
force-pushed
the
bug_12798/epoch_in_software_versions_is_not_stored_by_zypper_and_yum_module_which_breaks_version_detection
branch
from
c111b32
to
2077333
Compare
amousset
changed the title
peckpeck
approved these changes
Jun 20, 2018
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12798