Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12997: ncf_package unsupported "absence" of "latest" version of a package is not clear enough #795

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Jul 18, 2018

@@ -120,8 +120,10 @@ bundle agent ncf_package(name, version, architecture, provider, state, options)
"version_description" string => "in version ${version}";

# Log message
any::
any.!(!state_present.version_latest)::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be simplified

@Fdall Fdall force-pushed the bug_12997/ncf_package_unsupported_absence_of_latest_version_of_a_package_is_not_clear_enough branch from e986277 to 6339eec Compare July 18, 2018 12:57
@Fdall
Copy link
Contributor Author

Fdall commented Jul 18, 2018

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/795
-- Your faithful QA

@Fdall
Copy link
Contributor Author

Fdall commented Jul 19, 2018

OK, merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants