Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #13278: Service test do not use any service to test on suse #817

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Fixes #13278: Service test do not use any service to test on suse #817

merged 1 commit into from
Aug 28, 2018

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Aug 23, 2018

amousset
amousset reviewed Aug 27, 2018
View reviewed changes
tests/acceptance/30_generic_methods/unsafe/service_reload.cf Outdated
"service_script" string => "cron";

classes:
"running" expression => returnszero("service ${service_script} start", "useshell");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is it used?

@Fdall Fdall force-pushed the bug_13278/service_test_do_not_use_any_service_to_test_on_suse branch from afc0cac to aed8130 Compare August 27, 2018 16:25
@Fdall
Copy link
Contributor Author

Fdall commented Aug 27, 2018

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Rudder-Jenkins Normation-Rudder-Jenkins merged commit aed8130 into Normation:branches/rudder/4.1 Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
No milestone
4 participants
@Fdall @Normation-Quality-Assistant @amousset @Normation-Rudder-Jenkins