Fixes #13638: zypper patterns tests should not be executed on non sles os #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Oct 12, 2018
| "repo_path" string => "/usr/share/ncf/tests/acceptance/30_generic_methods/modules/repo_rudder_tests"; | ||
| "pwd" string => dirname("${this.promise_filename}"); | ||
| "repo_path" string => "${pwd}/repo_rudder_tests"; | ||
| "ncf_path" string => "${pwd}/../../../../.."; |
There was a problem hiding this comment.
we should probably make it a global variable in a library :)
There was a problem hiding this comment.
We actually have one in the tests, ncf_tree
Fdall
force-pushed
the
bug_13638/zypper_patterns_tests_should_not_be_executed_on_non_sles_os
branch
from
3ba61c1
to
57442da
Compare
|
Commit modified |
Fdall
force-pushed
the
bug_13638/zypper_patterns_tests_should_not_be_executed_on_non_sles_os
branch
from
57442da
to
c148f48
Compare
|
Commit modified |
peckpeck
approved these changes
Oct 23, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/13638