Fixes #5245: Simpler regexp to parse bundle name #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
added a commit
that referenced
this pull request
Jul 8, 2014
Fixes #5245: Simpler regexp to parse bundle name
|
I'm not sure I agree with this change. While it is technically identical, it's intention is quite different. "\w" in regexps means "a word", however, the regexp I initially used meant "a valid CFEngine bundle or class name". This would of course have been more obvious if I'd declared a constant (something like "CFE_BUNDLE_REGEX". I feel that we're losing the original intent here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.