Fixes #13745: change the detection of curl path in ncf to use rudder_curl if available #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Oct 30, 2018
tree/20_cfe_basics/ncf_lib.cf
Outdated
| # Use rudder_curl variable if available, rather than the path[curl] | ||
| bundle common ncf_path { | ||
| vars: | ||
| "ncf_curl" string => "${g.rudder_curl}", |
There was a problem hiding this comment.
Could you put it in a path array for consistency with stdlib?
There was a problem hiding this comment.
And name the bundle ncf_paths?
There was a problem hiding this comment.
BTW I like this idea of overriding stdlib in ncf 👍
…curl if available
ncharles
force-pushed
the
bug_13745/change_the_detection_of_curl_path_in_ncf_to_use_rudder_curl_if_available
branch
from
24f5891
to
65175fb
Compare
|
Commit modified |
amousset
reviewed
Oct 31, 2018
| unless => isvariable("g.rudder_curl"); | ||
|
|
||
|
|
||
| "all_paths" slist => getindices("path"); |
amousset
reviewed
Oct 31, 2018
| "path[curl]" string => "${g.rudder_curl}", | ||
| if => isvariable("g.rudder_curl"); | ||
|
|
||
| "path[curl]" string => "${paths.path[curl]}", |
amousset
approved these changes
Oct 31, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/13745