Fixes #12857: File_absent GM can remove empty directories #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Nov 12, 2018
|
|
||
| "success_if_nothing" usebundle => _classes_success("${class_prefix}"), | ||
| ifvarclass => "has_promiser_stack.!${class_prefix}_reached"; | ||
| "report" usebundle => _log("${target} is a folder, and cannot be removed as a file", "${old_class_prefix}", "${class_prefix}", @{args}); |
There was a problem hiding this comment.
We should try to use "directory" everywhere in Rudder for consistence.
ncharles
force-pushed
the
bug_12857/file_absent_gm_can_remove_empty_directories
branch
from
3158a99
to
d2556b4
Compare
|
Commit modified |
amousset
approved these changes
Nov 13, 2018
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/12857