Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #14167: Generic method in 4.3 should not use the class has_promiser_stack #902

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Fixes #14167: Generic method in 4.3 should not use the class has_promiser_stack #902

merged 1 commit into from
Jan 21, 2019

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Jan 17, 2019

ncharles
ncharles requested changes Jan 21, 2019
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you replace all ${old_class_prefix}_reached.${class_prefix}_reached by ${old_class_prefix}_reached|${class_prefix}_reached please ?

tree/30_generic_methods/command_execution.cf Outdated Show resolved Hide resolved
tree/30_generic_methods/command_execution_result.cf Outdated Show resolved Hide resolved
tree/30_generic_methods/user_create.cf Outdated Show resolved Hide resolved
@Fdall Fdall force-pushed the bug_14167/generic_method_in_4_3_should_not_use_the_class_has_promiser_stack branch from dddbd64 to 6329129 Compare January 21, 2019 14:41
@Fdall
Copy link
Contributor Author

Fdall commented Jan 21, 2019

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 6329129 into Normation:branches/rudder/4.3 Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Fdall @Normation-Quality-Assistant @ncharles