-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #14517: Add a generic method to remove posix ACL #940
Fixes #14517: Add a generic method to remove posix ACL #940
Conversation
@@ -0,0 +1,184 @@ | |||
##################################################################################### | |||
# Copyright 2013 Normation SAS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2019, isn't it ?
{ | ||
vars: | ||
"old_class_prefix" string => canonify("permissions_posix_acls_absent_${path}"); | ||
"args" slist => { "${path}" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are missing "recursive" as an arg
"full_class_prefix" string => canonify("permissions_posix_acls_absent_${report_param}"); | ||
"class_prefix" string => string_head("${full_class_prefix}", "1000"); | ||
|
||
"wc_path" string => "/usr/bin/wc"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should go in the paths.cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still relevant
Commit modified |
"error_list" slist => getvalues("error"); | ||
"success_list" slist => getvalues("success"); | ||
|
||
"report_list" slist => { "@{error_list}", "@{repaired_list}", "@{success_list}" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it needs the policy => "ifdefined" also
This methods needs tests, specially as we implemented it and did not reuse a CFEngine promise here. |
Commit modified |
4 similar comments
Commit modified |
Commit modified |
Commit modified |
Commit modified |
PR rebased |
ab80991
to
0681d7e
Compare
Commit modified |
"class_prefix" string => string_head("${full_class_prefix}", "1000"); | ||
|
||
"wc_path" string => "/usr/bin/wc"; | ||
"detect_acl_command" string => ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unused
"success_${file_list}" usebundle => _classes_success("${inner_class_prefix[${file_list}]}"), | ||
ifvarclass => "!acls_found_${canonified_file_array[${file_list}]}.path_exists_${canonified_file_array[${file_list}]}"; | ||
|
||
# Execute setfacl -b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: executed
Commit modified |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
1c96cc6
to
13ab3cb
Compare
https://issues.rudder.io/issues/14517