Fixes #14638: Add a generic method to add ace for "other" on a given file #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdall
force-pushed
the
bug_14638/add_a_generic_method_to_add_ace_for_other_on_a_given_file
branch
from
476341c
to
71cb6b9
Compare
|
PR rebased |
ncharles
reviewed
Jun 24, 2019
| # | ||
| # @parameter path Path of the file or directory | ||
| # @parameter recursive Recursive Should ACLs cleanup be recursive, "true" or "false" (defaults to "false") | ||
| # @parameter other_ace ACE to enforce for the given other. |
There was a problem hiding this comment.
why the given other ? simply for "other"
Fdall
force-pushed
the
bug_14638/add_a_generic_method_to_add_ace_for_other_on_a_given_file
branch
2 times, most recently
from
7819b8e
to
7efe36f
Compare
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
Fixes #14638: Add a generic method to add ace for \"other\" on a given file
Fdall
force-pushed
the
bug_14638/add_a_generic_method_to_add_ace_for_other_on_a_given_file
branch
from
7efe36f
to
d03ac2a
Compare
ncharles
reviewed
Jun 25, 2019
| "set old classes" usebundle => _classes_copy("${class_prefix}", "${old_class_prefix}"); | ||
|
|
||
| is_recursive.pass3.files_found:: | ||
| "report" usebundle => _log_v3("${report_string} ${const.endl}Set POSIX acl ${other} recursively on ${path}", "${path}", "${old_class_prefix}", "${class_prefix}", @{args}); |
There was a problem hiding this comment.
on the rudder cli, it output "repaired: /tmp/acl", but in the interface it's ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14638