Fixes #14990: Remove local doc build when installing ncf #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
May 29, 2019
Makefile
Outdated
| # Install ncf in DESTDIR | ||
| install: build | ||
| install: | ||
| mkdir -p $(DESTDIR) | ||
| mkdir -p $(DESTDIR)/share/doc/ncf | ||
| $(CP_A) doc $(DESTDIR)/share/doc/ncf/ |
There was a problem hiding this comment.
you should remove this lone as doc will not be there.
|
Commit modified |
amousset
approved these changes
May 31, 2019
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
Fdall
force-pushed
the
ust_14990/remove_local_doc_build_when_installing_ncf
branch
from
c4c0cda
to
fcab277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14990