Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #22183: Ansible collection should support the renaming of the server packages starting 7.2+ #63

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions roles/rudder_relay/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
policy_server: rudder.server
server_version: 7.0
relay_version: 7.2
rudder_repository_username: ""
rudder_repository_password: ""
rudder_repository: repository.rudder.io
rudder_repository_url: ""
update_cache: yes
apt_key_url: "https://repository.rudder.io/apt/rudder_apt_key.pub"
rpm_key_url: "https://repository.rudder.io/rpm/rudder_rpm_key.pub"
rpm_key_url: "https://repository.rudder.io/rpm/rudder_rpm_key.pub"
4 changes: 2 additions & 2 deletions roles/rudder_relay/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,5 @@ dependencies:
rudder_update_cache: "{{ update_cache }}"
repository_username: "{{ rudder_repository_username }}"
repository_password: "{{ rudder_repository_password }}"
apt_key_url: "{{ rudder_apt_key_url }}"
rpm_key_url: "{{ rudder_rpm_key_url }}"
rudder_apt_key_url: "{{ apt_key_url }}"
rudder_rpm_key_url: "{{ rpm_key_url }}"
11 changes: 0 additions & 11 deletions roles/rudder_relay/molecule/default/Dockerfile.j2

This file was deleted.

6 changes: 6 additions & 0 deletions roles/rudder_relay/molecule/default/debian.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- name: Install Rudder Relay
apt:
name: rudder-relay
state: present
register: relay_installed
failed_when: (relay_installed is changed) or (relay_installed is failed)
12 changes: 7 additions & 5 deletions roles/rudder_relay/molecule/default/molecule.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
---
dependency:
name: galaxy
driver:
name: docker
platforms:
- name: centos8
image: geerlingguy/docker-centos8-ansible:latest

- name: instance
image: quay.io/centos/centos:stream8
command: /sbin/init
capabilities:
- SYS_ADMIN
volumes:
- /sys/fs/cgroup:/sys/fs/cgroup:ro
provisioner:
name: ansible

verifier:
name: ansible
6 changes: 6 additions & 0 deletions roles/rudder_relay/molecule/default/redhat.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- name: Install Rudder Relay
yum:
name: rudder-relay
state: present
register: relay_installed
failed_when: (relay_installed is changed) or (relay_installed is failed)
6 changes: 6 additions & 0 deletions roles/rudder_relay/molecule/default/sles.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- name: Install Rudder Relay
zypper:
name: rudder-relay
state: latest
register: relay_installed
failed_when: (relay_installed is changed) or (relay_installed is failed)
7 changes: 7 additions & 0 deletions roles/rudder_relay/molecule/default/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,10 @@
assert:
that:
- current_policy_server.stdout == "rudder.server"

- include_tasks: redhat.yml
when: ansible_os_family == "RedHat"
- include_tasks: debian.yml
when: ansible_os_family == "Debian"
- include_tasks: sles.yml
when: ansible_os_family == "Suse"
9 changes: 9 additions & 0 deletions roles/rudder_relay/molecule/old_versions/converge.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
- name: Converge
hosts: all
tasks:
- name: "Include rudder_relay"
include_role:
name: "rudder_relay"
vars:
relay_version: 7.1
6 changes: 6 additions & 0 deletions roles/rudder_relay/molecule/old_versions/debian.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- name: Install Rudder Relay
apt:
name: rudder-server-relay
state: present
register: relay_installed
failed_when: (relay_installed is changed) or (relay_installed is failed)
16 changes: 16 additions & 0 deletions roles/rudder_relay/molecule/old_versions/molecule.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
dependency:
name: galaxy
driver:
name: docker
platforms:
- name: instance
image: quay.io/centos/centos:stream8
command: /sbin/init
capabilities:
- SYS_ADMIN
volumes:
- /sys/fs/cgroup:/sys/fs/cgroup:ro
provisioner:
name: ansible
verifier:
name: ansible
6 changes: 6 additions & 0 deletions roles/rudder_relay/molecule/old_versions/redhat.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- name: Install Rudder Relay
yum:
name: rudder-server-relay
state: present
register: relay_installed
failed_when: (relay_installed is changed) or (relay_installed is failed)
6 changes: 6 additions & 0 deletions roles/rudder_relay/molecule/old_versions/sles.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- name: Install Rudder Relay
zypper:
name: rudder-server-relay
state: latest
register: relay_installed
failed_when: (relay_installed is changed) or (relay_installed is failed)
30 changes: 30 additions & 0 deletions roles/rudder_relay/molecule/old_versions/verify.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
---
# This is an example playbook to execute Ansible tests.

- name: Verify
hosts: all
tasks:
- name: Get rudder cli path
command: which rudder
register: rudder_path

- name: Get rudder policy server
command: cat /var/rudder/cfengine-community/policy_server.dat
register: current_policy_server

- name: Rudder-agent must be installed
assert:
that:
- rudder_path.stdout == "/usr/bin/rudder"

- name: Policy server must be configured
assert:
that:
- current_policy_server.stdout == "rudder.server"

- include_tasks: redhat.yml
when: ansible_os_family == "RedHat"
- include_tasks: debian.yml
when: ansible_os_family == "Debian"
- include_tasks: sles.yml
when: ansible_os_family == "Suse"
2 changes: 1 addition & 1 deletion roles/rudder_relay/tasks/debian.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- name: Install Rudder Relay
apt:
name: rudder-server-relay
name: "{{ rudder_relay_package_name }}"
state: latest
notify:
- Send inventory
6 changes: 6 additions & 0 deletions roles/rudder_relay/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- include_vars: "before_7.2.yml"
when: relay_version is version('7.2', '<')

- include_vars: "after_7.2.yml"
when: relay_version is version('7.2', '>=')

- include_tasks: sles.yml
when: ansible_os_family == "Suse"

Expand Down
2 changes: 1 addition & 1 deletion roles/rudder_relay/tasks/redhat.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- name: Install Rudder Relay
yum:
name: rudder-server-relay
name: "{{ rudder_relay_package_name }}"
state: latest
notify:
- Send inventory
2 changes: 1 addition & 1 deletion roles/rudder_relay/tasks/sles.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- name: Install Rudder Relay
zypper:
name: rudder-server-relay
name: "{{ rudder_relay_package_name }}"
state: latest
notify:
- Send inventory
2 changes: 2 additions & 0 deletions roles/rudder_relay/vars/after_7.2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rudder_server_package_name: "rudder-server"
rudder_relay_package_name: "rudder-relay"
2 changes: 2 additions & 0 deletions roles/rudder_relay/vars/before_7.2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rudder_server_package_name: "rudder-server-root"
rudder_relay_package_name: "rudder-server-relay"
2 changes: 1 addition & 1 deletion roles/rudder_server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#### Role variables

- `server_version`: Rudder version(default: `7.0`)
- `server_version`: Rudder version(default: `7.2`)
- `rudder_repository`: Rudder repository domain (default: `repository.rudder.io`)
- `rudder_repository_url`: Complete Rudder repository URL (default: `empty`), used only when not empty, replace the server_version and rudder_repository when used.
- `rudder_repository_username`: Optional username to pass to repository if using credentials
Expand Down
4 changes: 2 additions & 2 deletions roles/rudder_server/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
server_version: 7.0
server_version: 7.2
rudder_repository_username: ""
rudder_repository_password: ""
rudder_repository: repository.rudder.io
rudder_repository_url: ""
update_cache: yes
apt_key_url: "https://repository.rudder.io/apt/rudder_apt_key.pub"
rpm_key_url: "https://repository.rudder.io/rpm/rudder_rpm_key.pub"
rpm_key_url: "https://repository.rudder.io/rpm/rudder_rpm_key.pub"
4 changes: 2 additions & 2 deletions roles/rudder_server/molecule/default/debian.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- name: Install Rudder Agent
- name: Install Rudder Server
apt:
name: rudder-server-root
name: rudder-server
state: present
register: server_installed
failed_when: (server_installed is changed) or (server_installed is failed)
9 changes: 6 additions & 3 deletions roles/rudder_server/molecule/default/molecule.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@ driver:
name: docker
platforms:
- name: instance
image: geerlingguy/docker-centos8-ansible
pre_build_image: true
command: "yum update --disablerepo=appstream"
image: quay.io/centos/centos:stream8
command: /sbin/init
capabilities:
- SYS_ADMIN
volumes:
- /sys/fs/cgroup:/sys/fs/cgroup:ro
provisioner:
name: ansible
verifier:
Expand Down
4 changes: 2 additions & 2 deletions roles/rudder_server/molecule/default/redhat.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- name: Install Rudder Agent
- name: Install Rudder Server
yum:
name: rudder-server-root
name: rudder-server
state: present
register: server_installed
failed_when: (server_installed is changed) or (server_installed is failed)
4 changes: 2 additions & 2 deletions roles/rudder_server/molecule/default/sles.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- name: Install Rudder Agent
- name: Install Rudder Server
zypper:
name: rudder-server-root
name: rudder-server
state: latest
register: server_installed
failed_when: (server_installed is changed) or (server_installed is failed)
8 changes: 8 additions & 0 deletions roles/rudder_server/molecule/old_versions/converge.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
- name: Converge
hosts: all
tasks:
- name: "Include rudder_server"
include_role:
name: "rudder_server"
vars:
server_version: 7.1
6 changes: 6 additions & 0 deletions roles/rudder_server/molecule/old_versions/debian.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- name: Install Rudder Agent
apt:
name: rudder-server-root
state: present
register: server_installed
failed_when: (server_installed is changed) or (server_installed is failed)
16 changes: 16 additions & 0 deletions roles/rudder_server/molecule/old_versions/molecule.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
dependency:
name: galaxy
driver:
name: docker
platforms:
- name: instance
image: quay.io/centos/centos:stream8
command: /sbin/init
capabilities:
- SYS_ADMIN
volumes:
- /sys/fs/cgroup:/sys/fs/cgroup:ro
provisioner:
name: ansible
verifier:
name: ansible
6 changes: 6 additions & 0 deletions roles/rudder_server/molecule/old_versions/redhat.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- name: Install Rudder Agent
yum:
name: rudder-server-root
state: present
register: server_installed
failed_when: (server_installed is changed) or (server_installed is failed)
6 changes: 6 additions & 0 deletions roles/rudder_server/molecule/old_versions/sles.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- name: Install Rudder Agent
zypper:
name: rudder-server-root
state: latest
register: server_installed
failed_when: (server_installed is changed) or (server_installed is failed)
21 changes: 21 additions & 0 deletions roles/rudder_server/molecule/old_versions/verify.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
# This is an example playbook to execute Ansible tests.

- name: Verify
hosts: all
tasks:
- name: Get rudder cli path
command: which rudder
register: rudder_path

- name: Rudder-agent must be installed
assert:
that:
- rudder_path.stdout == "/usr/bin/rudder"

- include_tasks: redhat.yml
when: ansible_os_family == "RedHat"
- include_tasks: debian.yml
when: ansible_os_family == "Debian"
- include_tasks: sles.yml
when: ansible_os_family == "Suse"
2 changes: 1 addition & 1 deletion roles/rudder_server/tasks/debian.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- name: Install Rudder Server
apt:
name: rudder-server-root
name: "{{ rudder_server_package_name }}"
state: latest
6 changes: 6 additions & 0 deletions roles/rudder_server/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- include_vars: "before_7.2.yml"
when: server_version is version('7.2', '<')

- include_vars: "after_7.2.yml"
when: server_version is version('7.2', '>=')

- include_tasks: sles.yml
when: ansible_os_family == "Suse"

Expand Down
2 changes: 1 addition & 1 deletion roles/rudder_server/tasks/redhat.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- name: Install Rudder Server
yum:
name: rudder-server-root
name: "{{ rudder_server_package_name }}"
state: latest
2 changes: 1 addition & 1 deletion roles/rudder_server/tasks/sles.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- name: Install Rudder Server
zypper:
name: rudder-server-root
name: "{{ rudder_server_package_name }}"
state: latest
2 changes: 2 additions & 0 deletions roles/rudder_server/vars/after_7.2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rudder_server_package_name: "rudder-server"
rudder_relay_package_name: "rudder-relay"
2 changes: 2 additions & 0 deletions roles/rudder_server/vars/before_7.2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rudder_server_package_name: "rudder-server-root"
rudder_relay_package_name: "rudder-server-relay"