Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23905: Add allowed networks support to the ansible collection #72

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Dec 15, 2023

@Fdall Fdall requested a review from ncharles December 15, 2023 13:59
@Fdall
Copy link
Contributor Author

Fdall commented Dec 19, 2023

PR updated with a new commit

@Normation-Quality-Assistant

This PR breaks qa-test

-- stdout -- 
Branch 'master' set up to track remote branch 'master' from 'NRM'.
Your branch is up to date with 'NRM/master'.
Already up to date.
Your branch is up to date with 'NRM/master'.
[...]
Switched to branch 'master'
Switched to branch 'ust_23905/add_allowed_networks_support_to_the_ansible_collection_pr'
Rebasing (2/2)

                                                                                
Successfully rebased and updated refs/heads/ust_23905/add_allowed_networks_support_to_the_ansible_collection_pr.
Switched to branch 'master'
Switched to a new branch 'master_test'
./qa-test: 12: typos: not found

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-ansible/pull/72 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/78219/console)

@Fdall
Copy link
Contributor Author

Fdall commented Jan 5, 2024

OK, squash merging this PR

@Fdall Fdall force-pushed the ust_23905/add_allowed_networks_support_to_the_ansible_collection branch from a91b8a8 to 496aedd Compare January 5, 2024 13:46
@Fdall Fdall merged commit 496aedd into Normation:master Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants