This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Fixes #8192: Better document Node Api: include detail always returns \"default\" #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,9 +102,9 @@ HTTP/1.1 200 OK | |||
|
|
|||
| @apiParam (Mono) {Query} query A query json object like we use as query in NodeGroups. A three field json object { 'composition' : 'and', 'select' : 'node', 'where' : [{"objectType":"node","attribute":"OS","comparator":"eq","value":"Linux"}]}, That parameter can be replace by the three following (select, composition, where) | |||
| @apiParam (Mono) {String} [composition=and] Boolean operator to use between each criteria. Other value is "And" | |||
| @apiParam (Mono) {String} [select=node] What kid of data we wnt to include. Here we can get policy servers/relay by setting 'nodeAndPolicyServer' | |||
| @apiParam (Mono) {String} [select=node] What kid of data we want to include. Here we can get policy servers/relay by setting 'nodeAndPolicyServer' | |||
|
Aside from these comments this looks good! |
VinceMacBuche
force-pushed
the
bug_8192/better_document_node_api_include_detail_always_returns_default
branch
from
6f00611
to
5780677
Compare
|
PR updated |
|
All right, thanks @jooooooon ! Merging this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8192