This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Fixes #9375: Add documentation on new API to start remote agent run #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Close, do not merge now, it does not build |
|
Fixed! |
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_9375/add_documentation_on_new_api_to_start_remote_agent_run
branch
from
bf8d4a3
to
4fe48ff
Compare
fanf
previously requested changes
Jan 13, 2017
src/api_v2/node.md
Outdated
|
|
||
| @apiParam (Multi) {class} classes Set class passed as parameter to make it available during agent run. | ||
|
|
||
| @apiDescription This API allows to trigger an agent run on the target node. Response content a json stating if agent has started on each node. |
There was a problem hiding this comment.
You need to be more precise on the behavior of the api regarding node answer: what exactly the api is waiting for to build the json answer ?
src/api_v2/node.md
Outdated
| @apiUse nodeId | ||
| @apiParam (Multi) {class} classes Set class passed as parameter to make it available during agent run. | ||
|
|
||
| @apiDescription This API allows to trigger an agent run on the target node. Response is not a json but the actual agent output on the node. |
There was a problem hiding this comment.
This API allows to trigger an agent run on the target node. Response is the streamed agent output directly from the node (and so not in JSON).
|
@VinceMacBuche This needs to be rebased. |
|
ping @VinceMacBuche |
|
PR rebased |
VinceMacBuche
force-pushed
the
ust_9375/add_documentation_on_new_api_to_start_remote_agent_run
branch
from
4fe48ff
to
f21699f
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_9375/add_documentation_on_new_api_to_start_remote_agent_run
branch
from
f21699f
to
e3618e1
Compare
VinceMacBuche
dismissed
fanf’s stale review
Changes treated, Alexis will review again
amousset
reviewed
Apr 10, 2017
src/api_v2/nodes.md
Outdated
|
|
||
| @apiParam (Multi) {class} classes Set class passed as parameter to make it available during agent run. | ||
|
|
||
| @apiDescription This API allows to trigger an agent run on the target node. Response content a json stating if agent could be started on each node, but not if the run went fine and do not display any output from it. You cann see the result of the run in rudder web interface or in the each agent logs |
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_9375/add_documentation_on_new_api_to_start_remote_agent_run
branch
from
e3618e1
to
7788cfa
Compare
|
OK, merging this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9375