This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Fixes #16003: Add shared-folder get to API doc #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
ncharles
suggested changes
Oct 21, 2019
| @@ -8,7 +8,7 @@ This file describes shared-folder REST API | |||
| @apiName sharedFolderHash | |||
| @apiGroup Shared folder | |||
|
|
|||
| @apiDescription Allows checking for a file content hash, typically to check if an update is available. If the file hash matches the computed one, a `304` code is returned. If the file exists but does not match the hash (or the hash is absent), a `200` code id returned. Finally, if the file does not exist, a `404` code is returned. | |||
| @apiDescription Allows checking for a file content hash, typically to check if an update is available. If the file hash matches the computed one, a `304` code is returned. If the file exists but does not match the hash (or the hash is absent), a `200` code id returned. Finally, if the file does not exist, a `404` code is returned. Howerver, the returned `content-length` and `content-type` do not match those of the target file (accessible with a `GET`). The client has to authenticate with TLS client authentication using the agent certificate and key, the access is only granted to nodes that are managed by the relay. | |||
There was a problem hiding this comment.
i don't understand the However part (and there's a typo in however)
There was a problem hiding this comment.
The HEAD headers should be the same as what the same request with GET would give, but we don't really do that. I'll rephrase it.
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
ncharles
approved these changes
Oct 21, 2019
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
arch_16003/add_shared_folder_get_to_api_doc
branch
from
9c866ef
to
e87bae3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16003