Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6757: Broken link and misplaced page in documentation #115

Conversation

fanf
Copy link
Member

@fanf fanf commented Jun 15, 2015

There is three main action here:

  • remove 80_server_optimization.txt and move the corresponding text in 6_handbook/20_application_tuning.txt
  • add two part about jetty: outofmemory errors, so that is someone search for the term in the doc, he finds something, and how to configure the RAM.
  • correct all the links on these parts which were silently broken.

@fanf fanf force-pushed the bug_6757/broken_link_and_misplaced_page_in_documentation branch from 7a7adf2 to f30c33b Compare June 15, 2015 13:52
@fanf
Copy link
Member Author

fanf commented Jun 15, 2015

PR updated.

the chapter [[jetty, about Jetty configuration]] so that it is
the half of the RAM of the server, rounded down to the GB.
the chapter <<_configure_ram_allocated_to_jetty, about webapplication RAM configuration>>
so that it is the half of the RAM of the server, rounded down to the GB.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rounded down to the nearest GB

@jooooooon
Copy link
Member

I have read this PR and approve it.

I have proposed some English language improvements (well, mostly typos) that it would be nice to include. However, if there is a rush to publish this, feel free to merge the PR ASAP and add a later PR with the English fixes.


----

The heuristic to choose the amount of memory needed for the web application is described in <<_hardwareh_specifications, the Rudder hadware
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/hardwareh/hardware/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and

s/hadware/hardware

@fanf fanf force-pushed the bug_6757/broken_link_and_misplaced_page_in_documentation branch from f30c33b to 421557a Compare June 30, 2015 15:50
@fanf fanf force-pushed the bug_6757/broken_link_and_misplaced_page_in_documentation branch from 421557a to 357d0df Compare June 30, 2015 15:51
@fanf
Copy link
Member Author

fanf commented Jun 30, 2015

PR updated for the typos, self merging it.

fanf added a commit that referenced this pull request Jun 30, 2015
…page_in_documentation

Fixes #6757: Broken link and misplaced page in documentation
@fanf fanf merged commit f29d181 into Normation:branches/rudder/2.10 Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants