Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7115: Fix favicon link #133

Merged

Conversation

amousset
Copy link
Member

@jooooooon
Copy link
Member

Hmmm. I'm confused here @amousset, I don't see what problem this is fixing. Your ticket doesn't explain any symptoms (just a proposed solution), so I can't understand your motivation here.

On http://www.rudder-project.org, this doc is displayed in a sub-directory (/doc), so the favicon used is the one from the above website (and this works for me currently). So I don't see what is broken there. Are you experiencing favicon trouble on other locations for this doc, or other errors?

Either way, please clarify the ticket, to describe the problem (not just the proposed solution), because currently I don't see any reason for this change. It does, however, look technically correct!

@amousset
Copy link
Member Author

Updated description in https://www.rudder-project.org/redmine/issues/7115

@jooooooon
Copy link
Member

Thanks, I get it now. I didn't realise the docs pointed to their own favicon.

jooooooon added a commit that referenced this pull request Aug 19, 2015
@jooooooon jooooooon merged commit 506fefc into Normation:branches/rudder/2.10 Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants