Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3831 - Add documentation about rsync modules from rudder-project #16

Merged
merged 2 commits into from
Aug 26, 2013
Merged

Fixes #3831 - Add documentation about rsync modules from rudder-project #16

merged 2 commits into from
Aug 26, 2013

Conversation

nperron
Copy link
Contributor

@nperron nperron commented Aug 13, 2013

Fixes #3831 - Add documentation about rsync modules from rudder-project

@nperron
Copy link
Contributor Author

nperron commented Aug 13, 2013

It will add this tip several times inthe documentation:

rsync_modules_doc

@jooooooon
Copy link
Member

The text you have added looks great, and this is an important possibility to be documented.

However, this is advanced usage, and I don't think it should be cluttering up the installation documentation, which I would like to keep as short and simple as possible. Also, this text is repeated a lot of times.

How about you add a section in the "Advanced" chapter for creating mirror repos instead?

@nperron
Copy link
Contributor Author

nperron commented Aug 23, 2013

Okay, I totally agree !

@nperron
Copy link
Contributor Author

nperron commented Aug 23, 2013

I've rebased another commit which will add another chapter named "mirroring Rudder repositories" into the section "Advanced usage"

@@ -0,0 +1,17 @@
=== Mirroring Rudder repositories

==== Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

@nperron
Copy link
Contributor Author

nperron commented Aug 26, 2013

Pull Request URL updated

@jooooooon
Copy link
Member

Great, thanks! Merging.

jooooooon added a commit that referenced this pull request Aug 26, 2013
…module

Fixes #3831 - Add documentation about rsync modules from rudder-project
@jooooooon jooooooon merged commit 44c8d20 into Normation:branches/rudder/2.4 Aug 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants