Fixes #8755: Document node properties #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ---- | ||
|
|
||
| ${node.properties[mykey]} |
There was a problem hiding this comment.
Please use real-life examples wherever possible. "datacenter=Paris" is a good example (here, just replace "mykey" by "datacenter" twice)
|
Commit modified |
peckpeck
force-pushed
the
ust_8755/document_node_properties
branch
from
2d0c296
to
04f588f
Compare
|
|
||
| Node properties can be found in the "properties" tab of each node in Rudder. | ||
|
|
||
| Node properties can be modified using Rudder API, see http://www.rudder-project.org/rudder-api-doc/#api-Nodes-updateNodeProperties |
There was a problem hiding this comment.
Does this appear as a link when the docs are built?
There was a problem hiding this comment.
If not, please make it a link.
There was a problem hiding this comment.
I cannot generate the doc at the moment, but it seems to work for other links in the documentation.
|
Commit modified |
peckpeck
force-pushed
the
ust_8755/document_node_properties
branch
from
04f588f
to
8707c30
Compare
|
|
||
| ---- | ||
|
|
||
| WARNING: currently node properties can not be used inside ${eval } JavaScript blocks, since they are evaluated during poliocy generation and node properties are only made available in the agents. A workaround for this will be provided in a future version of Rudder. |
There was a problem hiding this comment.
Oops, I made a typo, sorry: s/poliocy/policy/
|
This looks good to me apart from that one typo. Please fix and self-merge. |
|
Commit modified |
peckpeck
force-pushed
the
ust_8755/document_node_properties
branch
from
8707c30
to
d926ab4
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8755