Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9253: Cleanup node properties documentation #235

Conversation

jooooooon
Copy link
Member

@jooooooon
Copy link
Member Author

Commit modified

@jooooooon
Copy link
Member Author

This PR contains two commits: one with the actual changes, and a second one that renames a file to change the order of sections in the doc. Please review the first commit because that's where the changes are visible :)

@jooooooon
Copy link
Member Author

Ping @fanf

@jooooooon
Copy link
Member Author

@amousset Could you review this please? It needs merging pretty soon...

@Kegeruneku
Copy link

This looks perfect to me. Since this is a documentation update, I take the responsability to accept the merge :)

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 8f775bd into Normation:branches/rudder/3.1 Oct 19, 2016
@jooooooon
Copy link
Member Author

I would really have liked, and would still like, validation from @fanf that these documentation changes match the implementation.

François, please take 5 minutes to look over this and give a thumbs up or at least some pointers to say what needs changing if anything. This has been waiting for weeks now!

On 19 October 2016 20:07:54 CEST, Matthieu CERDA notifications@github.com wrote:

This looks perfect to me. Since this is a documentation update, I take
the responsability to accept the merge :)

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#235 (comment)

Sent from Kaiten Mail. Please excuse my brevity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants