Fixes #17353: Small fixes in variables page #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
May 12, 2020
fanf
reviewed
May 12, 2020
| - the second, focused on configuration file edition, is available through `Augeas` tools already presented for variable definition, | ||
| - the last, which covers involved file edition with possibly logic and loops, can be achieve through full fledge template engine. Rudder natively provides too of them: `Jinja2` and `Mustache`. | ||
| - the last, which covers involved file edition with possibly logic and loops, can be achieve through full-fledged template engine. Rudder natively provides too of them: `Jinja2` and `Mustache`. |
|
PR updated with a new commit |
fanf
approved these changes
May 13, 2020
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
ust_17353/small_fixes_in_variables_page
branch
from
45acdf6
to
b970c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17353