Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18467: Correct documentation about arrray merge for node properties #799

Conversation

fanf
Copy link
Member

@fanf fanf commented Nov 2, 2020

VinceMacBuche
VinceMacBuche previously approved these changes Nov 3, 2020
@fanf
Copy link
Member Author

fanf commented Nov 9, 2020

PR updated with a new commit

@fanf
Copy link
Member Author

fanf commented Nov 9, 2020

So, that documentation should be merged in 6.1 since we corrected the behavior (or more preciselly, let the option for the user to choose what behavior he wants) in 6.2.

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-doc/pull/799
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/32578/console)

@fanf
Copy link
Member Author

fanf commented Nov 17, 2020

OK, squash merging this PR

@fanf fanf force-pushed the bug_18467/correct_documentation_about_arrray_merge_for_node_properties branch from 27da1c1 to 18a193d Compare November 17, 2020 08:01
@fanf fanf merged commit 18a193d into Normation:branches/rudder/6.1 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants