Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20228: Document only ncf_const variables #863

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Nov 3, 2021

Fixes #20228: Document only ncf_const variables
@Fdall
Copy link
Contributor Author

Fdall commented Nov 5, 2021

PR updated with a new commit

Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see what would define these variables

@@ -541,22 +541,22 @@ There are also more variables available, all documented in https://docs.cfengine
|Name
|Description

|`const.dollar`
|`rudder_const.dollar`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have such on variable on my rudder 6.2

@ncharles
Copy link
Member

Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should states that these variables appears in 6.2.11 (or better, in 7.0) otherwise people with older version of rudder will have a broken config

@VinceMacBuche VinceMacBuche changed the base branch from branches/rudder/6.2 to branches/rudder/7.0 December 9, 2022 10:50
@VinceMacBuche VinceMacBuche changed the base branch from branches/rudder/7.0 to branches/rudder/7.1 December 9, 2022 10:50
@VinceMacBuche VinceMacBuche dismissed ncharles’s stale review December 9, 2022 10:51

PR was rebased on correct branch

VinceMacBuche
VinceMacBuche previously approved these changes Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants