Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20611: Some screenshots in documentation are too old #880

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fixes #20611: Some screenshots in documentation are too old #880

merged 1 commit into from
Jan 20, 2022

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Jan 20, 2022 •
edited
Loading

https://issues.rudder.io/issues/20611
We need to resize some screeshots I think... 馃槶

@ElaadF ElaadF requested a review from amousset January 20, 2022 14:37
@amousset
Copy link
Member

Can you also run make optipng in the repo to improve image size?

@ElaadF
Copy link
Member Author

ElaadF commented Jan 20, 2022

PR updated with a new commit

@ElaadF
Copy link
Member Author

ElaadF commented Jan 20, 2022

PR updated with a new commit

@ElaadF
Copy link
Member Author

ElaadF commented Jan 20, 2022

PR updated with a new commit

@ElaadF
Fixes #20611: Some screenshots in documentation are too old
4bd668d 
fixup! Fixes #20611: Some screenshots in documentation are too old

Fixes #20611: Some screenshots in documentation are too old

fixup! fixup! Fixes #20611: Some screenshots in documentation are too old

Fixes #20611: Some screenshots in documentation are too old

fixup! fixup! fixup! Fixes #20611: Some screenshots in documentation are too old

Fixes #20611: Some screenshots in documentation are too old
@ElaadF
Copy link
Member Author

ElaadF commented Jan 20, 2022

PR rebased

@ElaadF ElaadF force-pushed the bug_20611/some_screenshots_in_documentation_are_too_old branch from 6c6b8e9 to 4bd668d Compare January 20, 2022 15:43
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 4bd668d into Normation:branches/rudder/7.0 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
Ready for merge Trigger test
Projects
None yet
Milestone
No milestone
3 participants
@ElaadF @amousset @Normation-Quality-Assistant