Fixes #21223: Move create node doc in rudder core #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
force-pushed
the
arch_21223/move_create_node_api_doc_in_rudder_core
branch
from
34fcd49
to
0245141
Compare
ElaadF
commented
Jun 6, 2022
| - status, | ||
| - OS: type, name | ||
|
|
||
| Other information are possible. See the https://docs.rudder.io/api/#tag/Create-Node[plugin API documentation] for more information. |
There was a problem hiding this comment.
change the URL for the API
ElaadF
commented
Jun 6, 2022
|
|
||
| === Request format | ||
|
|
||
| The plugin provides a new API endpoint: PUT `/api/latest/nodes` |
There was a problem hiding this comment.
Modify if we decide to use another URL
ElaadF
commented
Jun 6, 2022
|
|
||
| The plugin provides a new API endpoint: PUT `/api/latest/nodes` | ||
|
|
||
| So for example, for curl: `curl -k -H "X-API-Token: 5YJnb4EenqDHzwx0U0eTPWWhgjTJ8mkk" -H "Content-Type: application/json" -X PUT 'https://your-server/rudder/api/latest/nodes' -d@/path/to/node.json` |
amousset
reviewed
Jun 6, 2022
|
|
||
| So for example, for curl: `curl -k -H "X-API-Token: 5YJnb4EenqDHzwx0U0eTPWWhgjTJ8mkk" -H "Content-Type: application/json" -X PUT 'https://your-server/rudder/api/latest/nodes' -d@/path/to/node.json` | ||
|
|
||
| With "node.json" expected to be a JSON file with the following format: |
There was a problem hiding this comment.
If think we should just describe the goal and the general behavior of the feature here, API details should be a link to API docs.
3 tasks
ElaadF
changed the title
|
PR updated with a new commit |
fanf
approved these changes
Jun 17, 2022
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
arch_21223/move_create_node_api_doc_in_rudder_core
branch
from
3072c35
to
fe983a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21223