Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21311: Wrong API url for creating nodes #909

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Jun 21, 2022

@ElaadF ElaadF requested a review from fanf June 21, 2022 15:11
@@ -15,7 +15,7 @@ A node need at least the following information:
- status,
- OS: type, name

Other information are possible. See the https://docs.rudder.io/api/#tag/Create-Node[plugin API documentation] for more information.
Other information are possible. See the https://docs.rudder.io/api/#tag/Nodes/operation/createNode[API documentation] for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be createNodes ?

@ElaadF
Copy link
Member Author

ElaadF commented Jun 22, 2022

PR updated with a new commit

@ElaadF ElaadF requested a review from fanf June 22, 2022 09:02
@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the bug_21311/wrong_api_url_for_creating_nodes branch from 26e84dd to dae5bde Compare June 22, 2022 09:43
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit dae5bde into Normation:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants