This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
Fixes #10351: Make datasources behaviour on 404 request configurable #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase in one commit ? |
| @@ -230,6 +230,61 @@ <h4 class="no-margin"> | |||
| </ul> | |||
| </div> | |||
| </div> | |||
| <div class="form-group"> | |||
| <label class="bloc"><a ng-click="toggleWell($event)">What to do when a queries for a node returns Error 404 (missing)?<span class="fa fa-chevron-right"></span></a></label> | |||
There was a problem hiding this comment.
What to do when a query for a Node returns a 404 error?
| def extractMissingNodeBehavior(json: JValue) : Box[M[MissingNodeBehavior]] = { | ||
| val onMissing: Box[MissingNodeBehavior] = (json \ "onMissing" match { | ||
| case JNothing => Full(MissingNodeBehavior.Delete) | ||
| case JObject(fields) => fields.find( _.name == "name" ) match { |
There was a problem hiding this comment.
I would:
case obj : JObject =>
obj \ "name" match {
case JString(Delete.name) => Full(Delete)
...
case JString(Default.name) =>
obj \ "value" match {
case JNothing => Failure
case value => value
}
}
| //we only get the first element from the path. | ||
| //if list is empty, return "" (remove property). | ||
| DataSource.nodeProperty(datasourceName.value, json.headOption.getOrElse("")) | ||
| json.map( list => DataSource.nodeProperty(datasourceName.value, list.headOption.getOrElse("")) ) |
There was a problem hiding this comment.
I had to read it thrice but it's ok :) ( In first attempt, i thought the None (NoChange) would be transformed into "" and would Delete the property but understood !!
VinceMacBuche
suggested changes
Apr 5, 2017
| MyDatasource.http.queryAll(datasource, c) match { | ||
| case Full(res) => //ok | ||
| case x => logger.error(s"oh no! Got a $x") | ||
| // "Update on datasource" should { |
There was a problem hiding this comment.
Do you want it to be commented ??? I think we should remove if so
There was a problem hiding this comment.
nope :) it was because it took to long when testing, and eclipse does not help a lot to start only one test
|
PR rebased |
fanf
force-pushed
the
ust_10351/make_datasources_behaviour_on_404_request_configurable
branch
from
873efba
to
6b18d7f
Compare
|
PR rebased |
fanf
force-pushed
the
ust_10351/make_datasources_behaviour_on_404_request_configurable
branch
from
6b18d7f
to
361d863
Compare
|
OK, merging this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10351