This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
Fixes #10102: Package datasource plugin properly #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may wait for the package manager to be merge first. To make sure this works. |
|
It is ok for me, to, sorry forgot to tell. |
|
@peckpeck Do you want to test it again before merging? |
amousset
reviewed
Mar 2, 2017
packaging/metadata
Outdated
| "version": "${plugin-version}", | ||
| "build-date": "${maven.build.timestamp}", | ||
| "build-commit": "${commit-id}", | ||
| "jar-files": [ "datasources.jar" ], |
There was a problem hiding this comment.
@peckpeck This now needs to be a full path
|
Commit modified |
peckpeck
force-pushed
the
arch_10102/package_datasource_plugin_properly
branch
from
263153f
to
42aaea3
Compare
|
OK, merging this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10102