Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #13496: Centreon plugin doesn't work with python 2.7 #101

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Fixes #13496: Centreon plugin doesn't work with python 2.7 #101

merged 1 commit into from
Sep 17, 2018

Conversation

peckpeck
Copy link
Member

@peckpeck peckpeck force-pushed the bug_13496/centreon_plugin_doesn_t_work_with_python_2_7 branch from ba3a108 to 940e828 Compare September 17, 2018 15:24
@peckpeck
Copy link
Member Author

Commit modified

amousset
amousset reviewed Sep 17, 2018
View reviewed changes
centreon/bin/centreon-plugin.py
try:
from configparser import ConfigParser
except:
from ConfigParser import ConfigParser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci python

amousset
amousset reviewed Sep 17, 2018
View reviewed changes
centreon/bin/centreon-plugin.py Outdated
@@ -140,11 +143,11 @@ def macroWasRegistered(node, macroKey, register):
return register.has_section(node) and register.has_option(node, macroKey)

def unregisterMacro(node, macroKey, register):
del register[node][macroKey]
register.demove_option(node, macroKey)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demove_option ?

@peckpeck peckpeck force-pushed the bug_13496/centreon_plugin_doesn_t_work_with_python_2_7 branch from 940e828 to c2df6fb Compare September 17, 2018 15:31
@peckpeck
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit c2df6fb into Normation:branches/rudder/4.3 Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@peckpeck @Normation-Quality-Assistant @amousset