Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #14534: Change validation doesn't work with elm 0.19 #156

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fixes #14534: Change validation doesn't work with elm 0.19 #156

merged 1 commit into from
Mar 27, 2019

Conversation

ncharles
Copy link
Member

@ncharles
Copy link
Member Author

Caution: the UI is catastrophic

@fanf
Copy link
Member

fanf commented Mar 26, 2019

what does "Caution: the UI is catastrophic" mean?

@ncharles
Copy link
Member Author

it looks like that:
image

@fanf
Copy link
Member

fanf commented Mar 26, 2019

well, perhaps we should not merge that PR until the css part is solved, then?

@ncharles ncharles force-pushed the bug_14534/change_validation_doesn_t_work_with_elm_0_19 branch from 091953c to e830b00 Compare March 27, 2019 09:13
@ncharles
Copy link
Member Author

Commit modified

@ncharles
Copy link
Member Author

CSS is correctly loaded now

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit e830b00 into Normation:branches/rudder/5.0 Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ncharles @fanf @Normation-Quality-Assistant @VinceMacBuche