Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15113: Missing logs in change validation plugin #171

Merged
merged 1 commit into from Nov 13, 2019
Merged

Fixes #15113: Missing logs in change validation plugin #171

merged 1 commit into from Nov 13, 2019

Conversation

ncharles
Copy link
Member

fanf
fanf requested changes Jul 3, 2019
View reviewed changes
...tion/src/main/scala/com/normation/plugins/changevalidation/ChangeRequestJdbcRepository.scala Outdated
case None => Failure(s"The newly saved change request with ID ${id} was not found back in data base")
case None =>
val msg = s"The newly saved change request with ID ${id} was not found back in data base"
logger.error(msg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use ChangeValidationLogger everywhere ? It would be more consistant for users.

@ncharles ncharles force-pushed the bug_15113/missing_logs_in_change_validation_plugin branch 2 times, most recently from 1b91003 to 19838c1 Compare November 13, 2019 13:40
@ncharles
Copy link
Member Author

Commit modified

@ncharles ncharles force-pushed the bug_15113/missing_logs_in_change_validation_plugin branch from 19838c1 to 176f195 Compare November 13, 2019 13:40
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 176f195 into Normation:branches/rudder/5.0 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ncharles @Normation-Quality-Assistant @fanf