Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15306: Update link in readme to rudder.io and missing smarttag for create-node-api #178

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Fixes #15306: Update link in readme to rudder.io and missing smarttag for create-node-api #178

merged 2 commits into from
Jul 29, 2019

Conversation

fanf
Copy link
Member

@fanf fanf commented Jul 25, 2019

@fanf fanf requested a review from amousset July 25, 2019 09:46
@fanf fanf self-assigned this Jul 25, 2019
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-plugins/pull/178
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/12837/console)

@fanf
Copy link
Member Author

fanf commented Jul 29, 2019

OK, merging this PR

@fanf fanf merged commit c17ab25 into Normation:branches/rudder/5.0 Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees

@fanf fanf

Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@fanf @Normation-Quality-Assistant @amousset