Fixes #16024: Make a plugin from the current OpenSCAP technique #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdall
force-pushed
the
bug_16024/make_a_plugin_from_the_current_openscap_technique
branch
from
f67952f
to
5d00fbd
Compare
|
Commit modified |
amousset
reviewed
Oct 23, 2019
ansible-report/README.asciidoc
Outdated
| @@ -0,0 +1,89 @@ | |||
| # Rudder plugin: ansible_report | |||
There was a problem hiding this comment.
File extension needs to be .adoc
|
PR updated with a new commit |
amousset
reviewed
Oct 23, 2019
ansible-report/packaging/prerm
Outdated
| git rm -r $folder/$NAME | ||
| done | ||
| git commit -m "Ansible-report plugin uninstallation" | ||
| # need to be run 2 times to be updated, first one will fail |
There was a problem hiding this comment.
Not really the error given is the following:
- rudder server reload-techniques
error: Could not reload techniques from files
Error: An error occured when updating the Technique library from file system
cause:Error when trying to delete category with ID 'ActiveTechniqueCategoryId(ansible_report)'
cause:Can not delete 'techniqueCategoryId=ansible_report,techniqueCategoryId=Active Techniques,ou=Rudder,cn=rudder-configuration': subordinate objects must be deleted first
There was a problem hiding this comment.
Ok, could you open a ticket and add the link in a comment with a TODO to remove it?
Fdall
changed the title
Fdall
force-pushed
the
bug_16024/make_a_plugin_from_the_current_openscap_technique
branch
from
8e99750
to
d710fee
Compare
Fdall
changed the title
amousset
reviewed
Oct 24, 2019
| set -x | ||
|
|
||
| # Import Ansible Technique | ||
| FOLDERS="ncf/50_techniques/plugin_openscap_report techniques/plugin_openscap_report techniques/ncf_techniques" |
There was a problem hiding this comment.
why committing the whole techniques/ncf_techniques folder?
amousset
approved these changes
Oct 24, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16048