Fixes #16381: Modify makefile to use pdfs from our private repos #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
Dec 9, 2019
amousset
reviewed
Dec 9, 2019
cis/Makefile
Outdated
| pdfs: | ||
| mkdir pdfs | ||
| $(GET) pdfs/cis_debian9.pdf https://publisher.normation.com/build-dependencies/cis_debian9.pdf $(DEBIAN9_SHA256) | ||
| $(GET) pdfs/cis_redhat7.pdf https://publisher.normation.com/build-dependencies/cis_redhat7.pdf $(REDHAT7_SHA256) |
There was a problem hiding this comment.
could you put them in a cis folder? We'll probably have other dependencies there.
|
PR updated with a new commit |
amousset
approved these changes
Dec 9, 2019
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_16381/modify_makefile_to_use_pdfs_from_our_private_repos
branch
from
b78061f
to
962778d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16381