Fixes #16535: Missing scheme error when adding an user from the UI #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
force-pushed
the
bug_16535/missing_scheme_error_when_adding_an_user_from_the_ui
branch
from
2011b03
to
f4da7f0
Compare
fanf
reviewed
Jan 13, 2020
| @@ -139,20 +136,20 @@ object UserManagementService { | |||
| } | |||
|
|
|||
| def add(newUser: User): Box[User] = { | |||
| logger.info(s"path : ${getUserFilePath}") | |||
There was a problem hiding this comment.
I don't thing we want that modification
ElaadF
force-pushed
the
bug_16535/missing_scheme_error_when_adding_an_user_from_the_ui
branch
from
f4da7f0
to
3cc3875
Compare
fanf
approved these changes
Jan 14, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16535