-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #16567: Be able to add a hashed password #227
Fixes #16567: Be able to add a hashed password #227
Conversation
9f6c651
to
adbfdff
Compare
adbfdff
to
b689236
Compare
@@ -65,6 +67,8 @@ type alias Model = | |||
, userFocusOn : User | |||
, password : String | |||
, login : String | |||
, hashedPasswd : Bool | |||
, clearPasswd : Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need both boolean, I would only keep hashedPassword
else | ||
({model | addMod = On, editMod = Off}, Cmd.none) | ||
ActivePanelSettings username -> | ||
({model | addMod = Off, editMod = On, userFocusOn = username}, Cmd.none) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could have the same thing for to close modification if you click on the same user name
if editMod = On and userFocusOn = username
editMode = Off
else
on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also need to change you model so you don't have addMod and EditMod but a panelMode of type PanelMode that has 3 value : Closed | AddMode | EditMode String (the username we modify)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will allow to remove from model the "userFocusOn"
OK, merging this PR |
https://issues.rudder.io/issues/16567