Fixes #16567: Be able to add a hashed password #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
force-pushed
the
ust_16567/be_able_to_add_a_hashed_password
branch
6 times, most recently
from
9f6c651
to
adbfdff
Compare
ElaadF
force-pushed
the
ust_16567/be_able_to_add_a_hashed_password
branch
from
adbfdff
to
b689236
Compare
VinceMacBuche
approved these changes
Jan 24, 2020
| @@ -65,6 +67,8 @@ type alias Model = | |||
| , userFocusOn : User | |||
| , password : String | |||
| , login : String | |||
| , hashedPasswd : Bool | |||
| , clearPasswd : Bool | |||
There was a problem hiding this comment.
I don't think you need both boolean, I would only keep hashedPassword
| else | ||
| ({model | addMod = On, editMod = Off}, Cmd.none) | ||
| ActivePanelSettings username -> | ||
| ({model | addMod = Off, editMod = On, userFocusOn = username}, Cmd.none) |
There was a problem hiding this comment.
maybe we could have the same thing for to close modification if you click on the same user name
if editMod = On and userFocusOn = username
editMode = Off
else
on
There was a problem hiding this comment.
I think you also need to change you model so you don't have addMod and EditMod but a panelMode of type PanelMode that has 3 value : Closed | AddMode | EditMode String (the username we modify)
There was a problem hiding this comment.
This will allow to remove from model the "userFocusOn"
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16567