Fixes #16926: Port datasources to zio RC18-2 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
| @@ -201,10 +201,10 @@ | |||
| <dependency><groupId>commons-fileupload</groupId><artifactId>commons-fileupload</artifactId><scope>provided</scope></dependency> | |||
| <dependency><groupId>commons-io</groupId><artifactId>commons-io</artifactId><scope>provided</scope></dependency> | |||
| <dependency><groupId>commons-lang</groupId><artifactId>commons-lang</artifactId><scope>provided</scope></dependency> | |||
| <dependency><groupId>dev.zio</groupId><artifactId>izumi-reflect-thirdparty-boopickle-shaded_${scala-binary-version}</artifactId><scope>provided</scope></dependency> | |||
There was a problem hiding this comment.
Why do we need to adjust dependencies on plugins-common ?
There was a problem hiding this comment.
they changed some dependencies when switching to zio RC18-2.
Maven don't manage the provided one correctly if we don't tell him like that, so it may put them in the rpkg (because it doesn't see that they are provided), which lead to bigger rpkg (and horror stories in case of version mismatch)
VinceMacBuche
approved these changes
Mar 18, 2020
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_16926/port_datasources_to_zio_rc18_2
branch
from
a6fb418
to
7484faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16926