Fixes #12391: Make maven faster and correct MAVEN_OPS #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Apr 9, 2018
makefiles/find_m2_repo.sh
Outdated
| #!/bin/sh | ||
|
|
||
| # | ||
| # This file help find ME_REPO. |
amousset
reviewed
Apr 9, 2018
makefiles/make-plugins-common.mk
Outdated
| @@ -8,7 +8,8 @@ include ../makefiles/global-vars.mk | |||
|
|
|||
|
|
|||
| # maven local repo | |||
| MAVEN_LOCAL_REPO = $(shell mvn help:evaluate -Dexpression="localRepository" | grep basedir | sed -e "s/.*>\(.*\)<.*/\1/") | |||
| MAVEN_LOCAL_REPO_DEF = ../makefiles/m2_repo.sh | |||
There was a problem hiding this comment.
Where is it used? This file does not seem to exist.
|
PR rebased |
fanf
force-pushed
the
arch_12391/make_maven_faster_and_correct_maven_ops
branch
from
0075f56
to
8d1b9fc
Compare
peckpeck
approved these changes
Apr 10, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12391