Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17205: Notifiy change validation request by email #299

Merged
merged 1 commit into from Sep 7, 2020
Merged

Fixes #17205: Notifiy change validation request by email #299

merged 1 commit into from Sep 7, 2020

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented May 11, 2020

@ElaadF ElaadF requested a review from VinceMacBuche May 11, 2020 09:12
@ElaadF
Copy link
Member Author

ElaadF commented May 11, 2020

Commit modified

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch from 3a2c33a to a0acc29 Compare May 11, 2020 09:13
@ElaadF
Copy link
Member Author

ElaadF commented May 25, 2020

PR rebased

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch from a0acc29 to f631b76 Compare May 25, 2020 13:47
VinceMacBuche
VinceMacBuche requested changes May 25, 2020
View reviewed changes
...e-validation/src/main/scala/com/normation/plugins/changevalidation/NotificationService.scala Outdated Show resolved Hide resolved
...e-validation/src/main/scala/com/normation/plugins/changevalidation/NotificationService.scala Outdated Show resolved Hide resolved
...e-validation/src/main/scala/com/normation/plugins/changevalidation/NotificationService.scala Outdated Show resolved Hide resolved
...e-validation/src/main/scala/com/normation/plugins/changevalidation/NotificationService.scala Outdated Show resolved Hide resolved
...e-validation/src/main/scala/com/normation/plugins/changevalidation/NotificationService.scala Outdated Show resolved Hide resolved
...e-validation/src/main/scala/com/normation/plugins/changevalidation/NotificationService.scala Outdated Show resolved Hide resolved
...e-validation/src/main/scala/com/normation/plugins/changevalidation/NotificationService.scala Outdated Show resolved Hide resolved
...e-validation/src/main/scala/com/normation/plugins/changevalidation/NotificationService.scala Outdated Show resolved Hide resolved
...e-validation/src/main/scala/com/normation/plugins/changevalidation/NotificationService.scala Show resolved Hide resolved
@ElaadF
Copy link
Member Author

ElaadF commented May 25, 2020

Commit modified

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch 2 times, most recently from 58f07c7 to a104eeb Compare May 25, 2020 21:06
@ElaadF
Copy link
Member Author

ElaadF commented May 25, 2020

Commit modified

1 similar comment
@ElaadF
Copy link
Member Author

ElaadF commented May 25, 2020

Commit modified

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch 2 times, most recently from 5b65ecc to f40afd3 Compare May 28, 2020 21:15
@ElaadF
Copy link
Member Author

ElaadF commented May 28, 2020

Commit modified

1 similar comment
@ElaadF
Copy link
Member Author

ElaadF commented May 29, 2020

Commit modified

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch from f40afd3 to eba1d08 Compare May 29, 2020 08:21
@ElaadF
Copy link
Member Author

ElaadF commented Jun 2, 2020

Commit modified

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch from eba1d08 to d64c5da Compare June 2, 2020 07:57
@ElaadF
Copy link
Member Author

ElaadF commented Jun 2, 2020

Commit modified

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch from d64c5da to 1831f48 Compare June 2, 2020 08:20
@ElaadF
Copy link
Member Author

ElaadF commented Jun 3, 2020

PR updated with a new commit

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch from 72998fd to 8ccc34e Compare June 3, 2020 13:49
@ElaadF
Copy link
Member Author

ElaadF commented Jun 3, 2020

Commit modified

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch from 8ccc34e to 47c8d17 Compare June 3, 2020 17:13
@ElaadF
Copy link
Member Author

ElaadF commented Jun 3, 2020

Commit modified

1 similar comment
@ElaadF
Copy link
Member Author

ElaadF commented Jun 17, 2020

Commit modified

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch from 47c8d17 to 4188be6 Compare June 17, 2020 09:35
@ElaadF ElaadF added the WIP label Jun 19, 2020
@ElaadF
Copy link
Member Author

ElaadF commented Jun 24, 2020

Commit modified

@ElaadF ElaadF requested a review from fanf September 2, 2020 07:28
fanf
fanf requested changes Sep 2, 2020
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart for user data in config file, it seems ok!

change-validation/src/main/resources/change-validation.conf Outdated Show resolved Hide resolved
@ElaadF
Copy link
Member Author

ElaadF commented Sep 2, 2020

PR updated with a new commit

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch 2 times, most recently from 357e38a to abd5905 Compare September 3, 2020 16:31
@ElaadF
Copy link
Member Author

ElaadF commented Sep 3, 2020

Commit modified

@ElaadF ElaadF force-pushed the ust_17205/notifiy_change_validation_request_by_email branch from abd5905 to 350dcec Compare September 4, 2020 08:45
@ElaadF
Copy link
Member Author

ElaadF commented Sep 4, 2020

Commit modified

@ElaadF ElaadF requested a review from fanf September 4, 2020 09:31
@ElaadF ElaadF removed the WIP label Sep 4, 2020
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 350dcec into Normation:branches/rudder/6.1 Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

@VinceMacBuche VinceMacBuche Awaiting requested review from VinceMacBuche

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
No milestone
5 participants
@ElaadF @peckpeck @VinceMacBuche @Normation-Quality-Assistant @fanf