Fixes #12646: Make branding plugin ready for classic plugin setup #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
requested changes
May 17, 2018
pom-template.xml
Outdated
| @@ -12,7 +12,7 @@ | |||
| <groupId>com.normation.rudder</groupId> | |||
| <artifactId>rudder-parent</artifactId> | |||
| <!-- here, we can't use ${rudder-build-version} because of maven limitation--> | |||
| <version>4.3.0~rc4-SNAPSHOT</version> | |||
| <version>4.3.2-SNAPSHOT</version> | |||
There was a problem hiding this comment.
I prefer that we use 4.3.0 to be sure to be source compatible with that version. We will update that value only in case of a module API breaking change, but it must be something exceptionnal and well documented.
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_12646/make_branding_plugin_ready_for_classic_plugin_setup
branch
from
e6623ac
to
5050897
Compare
fanf
approved these changes
May 17, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12646