Fixes #19147: Email notification should be disabled when no host server is configured #360
Conversation
| emailBody <- getContentFromTemplate(mf, emailConf, params) | ||
| emailSubject <- getSubjectFromTemplate(mf, emailConf.subject, params) | ||
| _ <- emailService.sendEmail(serverConfig, emailConf.toEnvelop(emailBody).copy(subject = emailSubject)) | ||
| _ <- ZIO.when(!serverConfig.smtpHostServer.isBlank) { |
There was a problem hiding this comment.
isEmpty not isBlank (we still support some old Java8 systems that does not support isBlank
ElaadF
force-pushed
the
bug_19147/email_notification_should_be_disabled_when_no_host_server_is_configured
branch
from
5d75b3e
to
4a648cb
Compare
|
Commit modified |
| emailSubject <- getSubjectFromTemplate(mf, emailConf.subject, params) | ||
| _ <- emailService.sendEmail(serverConfig, emailConf.toEnvelop(emailBody).copy(subject = emailSubject)) | ||
| _ <- ZIO.when(serverConfig.smtpHostServer.nonEmpty) { | ||
| for { |
There was a problem hiding this comment.
I think there should be an info log line in each case - oh, no the config is read on each notification.
OK, we need to add the info in the plugin page in a next version. (ie in the plugin page, something like "Email notification are [disabled (configure email server in /... to enable) | enable (comment config in .... to disable) ]
There was a problem hiding this comment.
Do you mean we want to log whether active or not when we try to send an email ?
There was a problem hiding this comment.
yes, but I forgot that we reread conf each time, so it would hard to spot when it changes from enable to disable (or opposite).
So in place of having a log when the config is read, we need to display the info somewhere else.
ElaadF
force-pushed
the
bug_19147/email_notification_should_be_disabled_when_no_host_server_is_configured
branch
from
4a648cb
to
5c6f211
Compare
|
Commit modified |
ElaadF
force-pushed
the
bug_19147/email_notification_should_be_disabled_when_no_host_server_is_configured
branch
from
5c6f211
to
9ab2a2a
Compare
|
Commit modified |
ElaadF
force-pushed
the
bug_19147/email_notification_should_be_disabled_when_no_host_server_is_configured
branch
from
9ab2a2a
to
8b1bc88
Compare
|
Moved to #364 |
https://issues.rudder.io/issues/19147