Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12752: Datasources plugin scheduler problems after updating/deleting a datasource #550

Conversation

fanf
Copy link
Member

@fanf fanf commented Mar 28, 2023

https://issues.rudder.io/issues/12752

The problem was an non evaluated RudderIO on save :/
I've added a test to check for that now.

@fanf fanf requested a review from VinceMacBuche March 28, 2023 14:40
@fanf fanf changed the base branch from branches/rudder/7.2 to branches/rudder/7.1 March 28, 2023 15:51
@fanf fanf changed the base branch from branches/rudder/7.1 to branches/rudder/7.2 March 28, 2023 15:52
@fanf
Copy link
Member Author

fanf commented Mar 28, 2023

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-plugins/pull/550
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/66613/console)

@VinceMacBuche
Copy link
Member

OK, squash merging this PR

@VinceMacBuche VinceMacBuche force-pushed the bug_12752/datasources_plugin_scheduler_problems_after_updating_deleting_a_datasource branch from ee73646 to a6c1402 Compare April 3, 2023 18:07
@VinceMacBuche VinceMacBuche merged commit a6c1402 into Normation:branches/rudder/7.2 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants